Bug 182712

Summary: [Web Animations] Support the copy constructors for KeyframeEffectReadOnly and KeyframeEffect
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews204 for win-future
none
Patch for landing none

Antoine Quint
Reported 2018-02-12 15:12:07 PST
[Web Animations] Support the copy constructors for KeyframeEffectReadOnly and KeyframeEffect
Attachments
Patch (17.11 KB, patch)
2018-02-12 15:16 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews204 for win-future (11.50 MB, application/zip)
2018-02-12 16:55 PST, EWS Watchlist 		no flags
Details
Patch for landing (17.04 KB, patch)
2018-02-12 17:11 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2018-02-12 15:16:01 PST
Created attachment 333636 [details] Patch
EWS Watchlist
Comment 2 2018-02-12 16:55:49 PST
Comment on attachment 333636 [details] Patch Attachment 333636 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6473515 New failing tests: http/tests/preload/onerror_event.html
EWS Watchlist
Comment 3 2018-02-12 16:55:59 PST
Created attachment 333648 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Dean Jackson
Comment 4 2018-02-12 17:02:15 PST
Comment on attachment 333636 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333636&action=review > Source/WebCore/animation/KeyframeEffect.cpp:49 > + UNUSED_PARAM(state); Just remove the "state" part of the parameter. > Source/WebCore/animation/KeyframeEffectReadOnly.cpp:404 > + UNUSED_PARAM(state); Ditto.
Antoine Quint
Comment 5 2018-02-12 17:11:47 PST
Created attachment 333649 [details] Patch for landing
WebKit Commit Bot
Comment 6 2018-02-12 17:28:32 PST
Comment on attachment 333649 [details] Patch for landing Clearing flags on attachment: 333649 Committed r228412: <https://trac.webkit.org/changeset/228412>
WebKit Commit Bot
Comment 7 2018-02-12 17:28:34 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-02-12 17:30:10 PST
<rdar://problem/37481146>
Note You need to log in before you can comment on or make changes to this bug.