| Summary: | [Web Animations] Support the copy constructors for KeyframeEffectReadOnly and KeyframeEffect | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||
| Component: | New Bugs | Assignee: | Antoine Quint <graouts> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, dino, ews-watchlist, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Antoine Quint
2018-02-12 15:12:07 PST
Created attachment 333636 [details]
Patch
Comment on attachment 333636 [details] Patch Attachment 333636 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6473515 New failing tests: http/tests/preload/onerror_event.html Created attachment 333648 [details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 333636 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333636&action=review > Source/WebCore/animation/KeyframeEffect.cpp:49 > + UNUSED_PARAM(state); Just remove the "state" part of the parameter. > Source/WebCore/animation/KeyframeEffectReadOnly.cpp:404 > + UNUSED_PARAM(state); Ditto. Created attachment 333649 [details]
Patch for landing
Comment on attachment 333649 [details] Patch for landing Clearing flags on attachment: 333649 Committed r228412: <https://trac.webkit.org/changeset/228412> All reviewed patches have been landed. Closing bug. |