Bug 182660

Summary: [Cocoa] Web Automation: provide a way to ask clients the type of a JavaScript dialog
Product: WebKit Reporter: Blaze Burg <bburg>
Component: WebDriverAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bburg, cgarcia, commit-queue, jlewis3, joepeck, mitz, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed Fix
none
For landing
none
Fix internal build none

Blaze Burg
Reported 2018-02-09 15:44:12 PST
Needed to properly implement W3C WebDriver, ยง18.4, Step 5 from the WebKit side.
Attachments
Proposed Fix (10.16 KB, patch)
2018-02-09 17:13 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
For landing (11.57 KB, patch)
2018-02-21 12:13 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Fix internal build (11.62 KB, patch)
2018-02-28 14:59 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-09 15:44:44 PST
<rdar://problem/37408183>
Blaze Burg
Comment 3 2018-02-09 17:13:17 PST
Created attachment 333540 [details] Proposed Fix
Carlos Garcia Campos
Comment 4 2018-02-10 00:41:12 PST
Comment on attachment 333540 [details] Proposed Fix This looks good to me, r=me because patch is trivial, but maybe an Apple reviewer should check the new Cocoa API.
Tim Horton
Comment 5 2018-02-13 13:45:35 PST
Comment on attachment 333540 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=333540&action=review wk2r=me > Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSessionDelegate.h:64 > +- (_WKAutomationSessionJavaScriptDialogType)_automationSession:(_WKAutomationSession *)automationSession typeOfCurrentJavaScriptDialogOnPage:(WKPageRef)page; These should still have availability macros, no?
Blaze Burg
Comment 6 2018-02-13 13:50:18 PST
Comment on attachment 333540 [details] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=333540&action=review >> Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSessionDelegate.h:64 >> +- (_WKAutomationSessionJavaScriptDialogType)_automationSession:(_WKAutomationSession *)automationSession typeOfCurrentJavaScriptDialogOnPage:(WKPageRef)page; > > These should still have availability macros, no? Hmm, yes. They shall match the availability of the related WKWebView delegate method above.
Blaze Burg
Comment 7 2018-02-21 12:13:49 PST
Created attachment 334402 [details] For landing
WebKit Commit Bot
Comment 8 2018-02-21 15:31:20 PST
Comment on attachment 334402 [details] For landing Clearing flags on attachment: 334402 Committed r228902: <https://trac.webkit.org/changeset/228902>
WebKit Commit Bot
Comment 9 2018-02-21 15:31:21 PST
All reviewed patches have been landed. Closing bug.
Matt Lewis
Comment 10 2018-02-22 10:01:12 PST
Reverted r228902 for reason: This broke internal builds. Committed r228920: <https://trac.webkit.org/changeset/228920>
Blaze Burg
Comment 11 2018-02-28 14:59:33 PST
Created attachment 334773 [details] Fix internal build
WebKit Commit Bot
Comment 12 2018-02-28 18:12:36 PST
Comment on attachment 334773 [details] Fix internal build Clearing flags on attachment: 334773 Committed r229117: <https://trac.webkit.org/changeset/229117>
WebKit Commit Bot
Comment 13 2018-02-28 18:12:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.