Bug 182651

Summary:

[RenderTreeBuilder] Move RenderRubyAsInline/AsBlock::takeChild mutation to a RenderTreeBuilder

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2018-02-09 14:24:04 PST

ssia

Comment 1 Radar WebKit Bug Importer 2018-02-09 14:24:29 PST

<rdar://problem/37405042>

Comment 2 zalan 2018-02-09 14:28:44 PST

Created attachment 333516 [details]
Patch

Comment 3 Antti Koivisto 2018-02-09 14:30:57 PST

Comment on attachment 333516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333516&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilderRuby.h:46
> +    RenderPtr<RenderObject>takeChild(RenderRubyAsBlock& parent, RenderObject& child);

Missing space after >

Comment 4 zalan 2018-02-09 14:34:31 PST

Created attachment 333518 [details]
Patch

Comment 5 WebKit Commit Bot 2018-02-09 15:22:40 PST

The commit-queue encountered the following flaky tests while processing attachment 333518 [details]:

imported/w3c/web-platform-tests/fetch/api/cors/cors-redirect-preflight.any.html bug 182270 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.

Comment 6 WebKit Commit Bot 2018-02-09 15:23:07 PST

Comment on attachment 333518 [details]
Patch

Clearing flags on attachment: 333518

Committed r228339: <https://trac.webkit.org/changeset/228339>

Comment 7 WebKit Commit Bot 2018-02-09 15:23:09 PST

All reviewed patches have been landed.  Closing bug.