Bug 182642

Summary: Improve of string.h include after r228317.
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: bmallocAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, fpizlo, ggaren, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Carlos Alberto Lopez Perez 2018-02-09 08:53:49 PST 
From https://bugs.webkit.org/show_bug.cgi?id=182563#c22
> (In reply to Carlos Alberto Lopez Perez from comment #20)
> > Committed r228317: <https://trac.webkit.org/changeset/228317>
> 
> We should avoid architecture-specific #includes whenever possible. Adding
> one #include <string.h> is not going to slow down the build very much at
> all; it's not worth the cost of the include guards, IMO.
Comment 1 Carlos Alberto Lopez Perez 2018-02-09 09:04:29 PST 
Created attachment 333493 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2018-02-09 09:06:16 PST 
Created attachment 333494 [details]
Patch
Comment 3 Carlos Alberto Lopez Perez 2018-02-09 10:03:07 PST 
Comment on attachment 333494 [details]
Patch

Clearing flags on attachment: 333494

Committed r228324: <https://trac.webkit.org/changeset/228324>
Comment 4 Carlos Alberto Lopez Perez 2018-02-09 10:03:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-02-09 10:04:26 PST 
<rdar://problem/37394750>