| Summary: | [RenderTreeBuilder] Move multicolumn descendant/sibling removal logic to RenderTreeBuilder | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2018-02-08 15:41:15 PST
Created attachment 333431 [details]
Patch
Comment on attachment 333431 [details] Patch Attachment 333431 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6424583 New failing tests: http/tests/preload/onerror_event.html Created attachment 333443 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
(In reply to Build Bot from comment #3) > Comment on attachment 333431 [details] > Patch > > Attachment 333431 [details] did not pass win-ews (win): > Output: http://webkit-queues.webkit.org/results/6424583 > > New failing tests: > http/tests/preload/onerror_event.html I don't think so. Comment on attachment 333431 [details] Patch Rejecting attachment 333431 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 333431, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ource/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp Hunk #1 succeeded at 367 with fuzz 1 (offset 196 lines). patching file Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.h Hunk #1 FAILED at 40. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/6433366 Created attachment 333496 [details]
Patch
Comment on attachment 333496 [details] Patch Clearing flags on attachment: 333496 Committed r228327: <https://trac.webkit.org/changeset/228327> All reviewed patches have been landed. Closing bug. |