Bug 182627

Summary: [RenderTreeBuilder] Move multicolumn spanner mutation logic to RenderTreeBuilder
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

alan
Reported 2018-02-08 14:53:25 PST
move all mutations to RenderTreeBuilder
Attachments
Patch (31.20 KB, patch)
2018-02-08 15:01 PST, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-08 14:53:50 PST
<rdar://problem/37367284>
alan
Comment 2 2018-02-08 15:01:38 PST
Created attachment 333427 [details] Patch
Antti Koivisto
Comment 3 2018-02-09 02:35:51 PST
Comment on attachment 333427 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333427&action=review > Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp:255 > +static bool gShiftingSpanner = false; Since the builder is stateful this can be later made a member variable.
WebKit Commit Bot
Comment 4 2018-02-09 07:05:19 PST
Comment on attachment 333427 [details] Patch Clearing flags on attachment: 333427 Committed r228320: <https://trac.webkit.org/changeset/228320>
WebKit Commit Bot
Comment 5 2018-02-09 07:05:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.