Bug 182627 - [RenderTreeBuilder] Move multicolumn spanner mutation logic to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move multicolumn spanner mutation logic to RenderTreeBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-08 14:53 PST by zalan
Modified: 2018-02-09 07:05 PST (History)
6 users (show)

See Also:

Attachments
Patch (31.20 KB, patch)
2018-02-08 15:01 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-02-08 14:53:25 PST 
move all mutations to RenderTreeBuilder
Comment 1 Radar WebKit Bug Importer 2018-02-08 14:53:50 PST 
<rdar://problem/37367284>
Comment 2 zalan 2018-02-08 15:01:38 PST 
Created attachment 333427 [details]
Patch
Comment 3 Antti Koivisto 2018-02-09 02:35:51 PST 
Comment on attachment 333427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333427&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp:255
> +static bool gShiftingSpanner = false;

Since the builder is stateful this can be later made a member variable.
Comment 4 WebKit Commit Bot 2018-02-09 07:05:19 PST 
Comment on attachment 333427 [details]
Patch

Clearing flags on attachment: 333427

Committed r228320: <https://trac.webkit.org/changeset/228320>
Comment 5 WebKit Commit Bot 2018-02-09 07:05:21 PST 
All reviewed patches have been landed.  Closing bug.