Bug 182625

Summary: Support GetArrayLength on ArrayStorage in the FTL
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 182731    
Attachments:
Description Flags
Patch saam: review+

Saam Barati
Reported 2018-02-08 14:24:40 PST
Right now we don't. I see that some JetStream subtest runs into this.
Attachments
Patch (8.75 KB, patch)
2018-02-13 06:24 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-02-13 02:10:45 PST
(In reply to Saam Barati from comment #0) > Right now we don't. I see that some JetStream subtest runs into this. Actually, we can see bunch of giving up FTL compilation in web-tooling-benchmark due to the lack of ArrayStorage support in operations (PutByVal etc.). Now FTL can compile even an Eval node. FTL coverage should be expanded :)
Yusuke Suzuki
Comment 2 2018-02-13 06:24:23 PST
Created attachment 333684 [details] Patch
Saam Barati
Comment 3 2018-02-13 09:11:16 PST
Comment on attachment 333684 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333684&action=review > Source/JavaScriptCore/ChangeLog:11 > + This fixes several FTL failures in web-tooling-benchmarks while we still need to support ArrayPush, FTL failures => FTL compilation failures
Yusuke Suzuki
Comment 4 2018-02-13 09:20:08 PST
Comment on attachment 333684 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333684&action=review Thank you. >> Source/JavaScriptCore/ChangeLog:11 >> + This fixes several FTL failures in web-tooling-benchmarks while we still need to support ArrayPush, > > FTL failures => FTL compilation failures Fixed.
Yusuke Suzuki
Comment 5 2018-02-13 09:29:12 PST
Committed r228421: <https://trac.webkit.org/changeset/228421>
Radar WebKit Bug Importer
Comment 6 2018-02-13 09:30:25 PST
<rdar://problem/37500450>
Note You need to log in before you can comment on or make changes to this bug.