| Summary: | Support GetArrayLength on ArrayStorage in the FTL | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 182731 | ||||||
| Attachments: |
|
||||||
|
Description
Saam Barati
2018-02-08 14:24:40 PST
(In reply to Saam Barati from comment #0) > Right now we don't. I see that some JetStream subtest runs into this. Actually, we can see bunch of giving up FTL compilation in web-tooling-benchmark due to the lack of ArrayStorage support in operations (PutByVal etc.). Now FTL can compile even an Eval node. FTL coverage should be expanded :) Created attachment 333684 [details]
Patch
Comment on attachment 333684 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333684&action=review > Source/JavaScriptCore/ChangeLog:11 > + This fixes several FTL failures in web-tooling-benchmarks while we still need to support ArrayPush, FTL failures => FTL compilation failures Comment on attachment 333684 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333684&action=review Thank you. >> Source/JavaScriptCore/ChangeLog:11 >> + This fixes several FTL failures in web-tooling-benchmarks while we still need to support ArrayPush, > > FTL failures => FTL compilation failures Fixed. Committed r228421: <https://trac.webkit.org/changeset/228421> |