Bug 182618

Summary: Simplify .gitignore's WebKitLibraries/win section.
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: New BugsAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bburg, bfulgham, commit-queue, don.olmstead, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ross Kirsling
Reported 2018-02-08 13:05:42 PST
Simplify .gitignore's WebKitLibraries/win section.
Attachments
Patch (4.60 KB, patch)
2018-02-08 13:07 PST, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2018-02-08 13:07:41 PST
Created attachment 333414 [details] Patch
Per Arne Vollan
Comment 2 2018-02-09 12:19:48 PST
Should there also be an exception for '!/WebKitLibraries/win/lib64/WebKitSystemInterface.lib'?
Don Olmstead
Comment 3 2018-02-09 12:24:52 PST
(In reply to Per Arne Vollan from comment #2) > Should there also be an exception for > '!/WebKitLibraries/win/lib64/WebKitSystemInterface.lib'? Currently thats not checked in. If it does get checked in at that point the .gitignore can be added to.
Per Arne Vollan
Comment 4 2018-02-09 12:31:52 PST
Comment on attachment 333414 [details] Patch R=me.
WebKit Commit Bot
Comment 5 2018-02-09 16:48:57 PST
Comment on attachment 333414 [details] Patch Clearing flags on attachment: 333414 Committed r228346: <https://trac.webkit.org/changeset/228346>
WebKit Commit Bot
Comment 6 2018-02-09 16:48:59 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-02-09 16:49:21 PST
<rdar://problem/37410476>
Note You need to log in before you can comment on or make changes to this bug.