Bug 182618 - Simplify .gitignore's WebKitLibraries/win section.
Summary: Simplify .gitignore's WebKitLibraries/win section.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-08 13:05 PST by Ross Kirsling
Modified: 2018-02-09 16:49 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.60 KB, patch)
2018-02-08 13:07 PST, Ross Kirsling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2018-02-08 13:05:42 PST 
Simplify .gitignore's WebKitLibraries/win section.
Comment 1 Ross Kirsling 2018-02-08 13:07:41 PST 
Created attachment 333414 [details]
Patch
Comment 2 Per Arne Vollan 2018-02-09 12:19:48 PST 
Should there also be an exception for '!/WebKitLibraries/win/lib64/WebKitSystemInterface.lib'?
Comment 3 Don Olmstead 2018-02-09 12:24:52 PST 
(In reply to Per Arne Vollan from comment #2)
> Should there also be an exception for
> '!/WebKitLibraries/win/lib64/WebKitSystemInterface.lib'?

Currently thats not checked in. If it does get checked in at that point the .gitignore can be added to.
Comment 4 Per Arne Vollan 2018-02-09 12:31:52 PST 
Comment on attachment 333414 [details]
Patch

R=me.
Comment 5 WebKit Commit Bot 2018-02-09 16:48:57 PST 
Comment on attachment 333414 [details]
Patch

Clearing flags on attachment: 333414

Committed r228346: <https://trac.webkit.org/changeset/228346>
Comment 6 WebKit Commit Bot 2018-02-09 16:48:59 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-02-09 16:49:21 PST 
<rdar://problem/37410476>