Bug 182594

Summary: Remove JavaScriptCore/ForwardingHeaders directory
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: JavaScriptCoreAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bburg, commit-queue, ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mark.lam: review+, don.olmstead: commit-queue-
Patch
bburg: commit-queue-
Patch none

Don Olmstead
Reported 2018-02-07 18:54:02 PST
Let's find out if this is possible as well.
Attachments
Patch (2.25 KB, patch)
2018-02-07 19:41 PST, Don Olmstead 		mark.lam: review+
don.olmstead: commit-queue-
DetailsFormatted DiffDiff
Patch (8.71 KB, patch)
2018-02-08 12:04 PST, Don Olmstead 		bburg: commit-queue-
DetailsFormatted DiffDiff
Patch (8.91 KB, patch)
2018-02-08 13:10 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-02-07 19:41:24 PST
Created attachment 333354 [details] Patch
Don Olmstead
Comment 2 2018-02-07 20:16:30 PST
Comment on attachment 333354 [details] Patch Apple bots are coming back green so maybe we can just do this? I'm not sure if this will have any effect on the Apple internal builds though.
Mark Lam
Comment 3 2018-02-07 20:32:01 PST
Comment on attachment 333354 [details] Patch r=me. We can roll back out if it breaks stuff.
Don Olmstead
Comment 4 2018-02-08 12:04:37 PST
Created attachment 333404 [details] Patch
Blaze Burg
Comment 5 2018-02-08 13:00:16 PST
In file included from /tmp/g-ir-cpp-hd5ja0ts.c:31:0: /home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/UIProcess/API/gtk/WebKitJavascriptResult.h:27:35: fatal error: JavaScriptCore/JSBase.h: No such file or directory #include <JavaScriptCore/JSBase.h> ^
Don Olmstead
Comment 6 2018-02-08 13:04:12 PST
(In reply to Brian Burg from comment #5) > In file included from /tmp/g-ir-cpp-hd5ja0ts.c:31:0: > /home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/UIProcess/API/gtk/ > WebKitJavascriptResult.h:27:35: fatal error: JavaScriptCore/JSBase.h: No > such file or directory > #include <JavaScriptCore/JSBase.h> > ^ Yea this seems to be a GTK only failure. I think it has to do with what I took out around https://trac.webkit.org/browser/trunk/Source/WebKit/PlatformGTK.cmake#L1146 Maybe Michael would have an idea there. I think it would have caught it in the FORWARDING_HEADERS_DIR though..
Don Olmstead
Comment 7 2018-02-08 13:10:28 PST
Created attachment 333415 [details] Patch Lets see if this makes GTK happy
Don Olmstead
Comment 8 2018-02-08 14:25:11 PST
I have no idea where the other bots are but they seemed happy with the last patch. I guess when jsc comes back I'll cq+ it and if it breaks something we'll roll it out.
WebKit Commit Bot
Comment 9 2018-02-08 17:09:42 PST
Comment on attachment 333415 [details] Patch Clearing flags on attachment: 333415 Committed r228302: <https://trac.webkit.org/changeset/228302>
WebKit Commit Bot
Comment 10 2018-02-08 17:09:44 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2018-02-08 17:10:24 PST
<rdar://problem/37372672>
Note You need to log in before you can comment on or make changes to this bug.