| Summary: | Remove JavaScriptCore/ForwardingHeaders directory | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||
| Component: | JavaScriptCore | Assignee: | Don Olmstead <don.olmstead> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, bburg, commit-queue, ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Don Olmstead
2018-02-07 18:54:02 PST
Created attachment 333354 [details]
Patch
Comment on attachment 333354 [details]
Patch
Apple bots are coming back green so maybe we can just do this? I'm not sure if this will have any effect on the Apple internal builds though.
Comment on attachment 333354 [details]
Patch
r=me. We can roll back out if it breaks stuff.
Created attachment 333404 [details]
Patch
In file included from /tmp/g-ir-cpp-hd5ja0ts.c:31:0:
/home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/UIProcess/API/gtk/WebKitJavascriptResult.h:27:35: fatal error: JavaScriptCore/JSBase.h: No such file or directory
#include <JavaScriptCore/JSBase.h>
^
(In reply to Brian Burg from comment #5) > In file included from /tmp/g-ir-cpp-hd5ja0ts.c:31:0: > /home/ews/ltilve-gtk-wk2-ews/WebKit/Source/WebKit/UIProcess/API/gtk/ > WebKitJavascriptResult.h:27:35: fatal error: JavaScriptCore/JSBase.h: No > such file or directory > #include <JavaScriptCore/JSBase.h> > ^ Yea this seems to be a GTK only failure. I think it has to do with what I took out around https://trac.webkit.org/browser/trunk/Source/WebKit/PlatformGTK.cmake#L1146 Maybe Michael would have an idea there. I think it would have caught it in the FORWARDING_HEADERS_DIR though.. Created attachment 333415 [details]
Patch
Lets see if this makes GTK happy
I have no idea where the other bots are but they seemed happy with the last patch. I guess when jsc comes back I'll cq+ it and if it breaks something we'll roll it out. Comment on attachment 333415 [details] Patch Clearing flags on attachment: 333415 Committed r228302: <https://trac.webkit.org/changeset/228302> All reviewed patches have been landed. Closing bug. |