Bug 182593

Summary: [CMake] Rename WEBKIT_MAKE_FORWARDING_HEADERS to WEBKIT_INSTALL_FRAMEWORK_HEADERS
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: NEW ---    
Severity: Normal CC: achristensen, annulen, Hironori.Fujii, lforschler, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Don Olmstead 2018-02-07 18:43:13 PST
WEBKIT_MAKE_FORWARDING_HEADERS isn't actually making forwarding headers its copying in the same manner that Xcode builds do for frameworks.
Comment 1 Don Olmstead 2018-02-07 18:49:09 PST
Created attachment 333348 [details]
Patch
Comment 2 Konstantin Tokarev 2018-02-08 01:03:03 PST
Comment on attachment 333348 [details]
Patch

I think naming macro "INSTALL" suggests that it should do install() internally, but this is not the case
Comment 3 Michael Catanzaro 2018-02-08 08:11:26 PST
Yeah I agree with Konstantin, the current name actually seems better to me.
Comment 4 Don Olmstead 2018-02-08 12:00:24 PST
(In reply to Michael Catanzaro from comment #3)
> Yeah I agree with Konstantin, the current name actually seems better to me.

How about WEBKIT_COPY_FRAMEWORK_HEADERS?
Comment 5 Don Olmstead 2018-02-08 12:01:18 PST
(In reply to Don Olmstead from comment #4)
> (In reply to Michael Catanzaro from comment #3)
> > Yeah I agree with Konstantin, the current name actually seems better to me.
> 
> How about WEBKIT_COPY_FRAMEWORK_HEADERS?

Or actually WEBKIT_MAKE_FRAMEWORK_HEADERS?

Forwarding isnt what its actually doing so I think that part needs to be dropped either way.
Comment 6 Michael Catanzaro 2018-02-08 12:03:31 PST
MAKE_FLATTENED_HEADERS?
Comment 7 Don Olmstead 2018-02-08 12:06:43 PST
(In reply to Michael Catanzaro from comment #6)
> MAKE_FLATTENED_HEADERS?

Its emulating what Cocoa frameworks do so thats why I said FRAMEWORK. I just don't want FORWARDING in there since that's what we're trying to nuke from orbit.

Also WTF and PAL will be doing this but they aren't technically flat at least not YET.
Comment 8 Fujii Hironori 2018-02-10 16:58:41 PST
I think WEBKIT_MAKE_FRAMEWORK_HEADERS should be unified into WEBKIT_FRAMEWORK and WEBKIT_FRAMEWORK should take arguments. 

WEBKIT_FRAMEWORK(
    WebCore
    PRIVATE_HEADER ...
    PUBLIC_HEADER ...
    PUBLIC_DERIRIVED_HEADER ...
    SOURCES ...
    ...)
Comment 9 Fujii Hironori 2018-02-10 21:45:02 PST
Comment on attachment 333348 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333348&action=review

> ChangeLog:10
> +        consistent with the actual behavior.

You want to rename the directory name ForwardingHeaders, too?
Comment 10 Don Olmstead 2018-02-12 10:56:43 PST
(In reply to Fujii Hironori from comment #8)
> I think WEBKIT_MAKE_FRAMEWORK_HEADERS should be unified into
> WEBKIT_FRAMEWORK and WEBKIT_FRAMEWORK should take arguments. 
> 
> WEBKIT_FRAMEWORK(
>     WebCore
>     PRIVATE_HEADER ...
>     PUBLIC_HEADER ...
>     PUBLIC_DERIRIVED_HEADER ...
>     SOURCES ...
>     ...)

Yea that makes sense. Might want the same behavior as it has with SOURCES and all that.

(In reply to Fujii Hironori from comment #9)
> Comment on attachment 333348 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=333348&action=review
> 
> > ChangeLog:10
> > +        consistent with the actual behavior.
> 
> You want to rename the directory name ForwardingHeaders, too?

I was thinking of doing something along those lines yes, but in a cleanup pass after everything is done.