Bug 182583

Summary:

[Curl] Cookie Database has some warnings when compiled in clang

Product:

WebKit

Reporter:

Christopher Reid <chris.reid>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, darin, don.olmstead, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Christopher Reid 2018-02-07 15:01:23 PST

Here are the warnings:
    - Unused parameters in CookieJarCurlDatabase and CookieJarDB.
    - The NetworkStorageSessionCurl constructor has a different order than its header.
    - I accidentally had a '#pragma once' in CookieJarCurlDatabase.cpp.
    - CookieJarDB.cpp(175,26): warning : missing field 'st_ino' initializer [-Wmissing-field-initializers]

Comment 1 Christopher Reid 2018-02-07 15:08:45 PST

Created attachment 333319 [details]
patch

Comment 2 WebKit Commit Bot 2018-02-07 16:39:22 PST

Comment on attachment 333319 [details]
patch

Clearing flags on attachment: 333319

Committed r228250: <https://trac.webkit.org/changeset/228250>

Comment 3 WebKit Commit Bot 2018-02-07 16:39:23 PST

All reviewed patches have been landed.  Closing bug.

Comment 4 Radar WebKit Bug Importer 2018-02-07 16:41:03 PST

<rdar://problem/37332502>