Summary: | Add missing #if ENABLE(VIDEO) after r228092. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ross Kirsling <ross.kirsling> | ||||||||||
Component: | WebCore Misc. | Assignee: | Ross Kirsling <ross.kirsling> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cdumez, commit-queue, don.olmstead, esprehn+autocc, ews-watchlist, gyuyoung.kim, mcatanzaro, Ms2ger, rniwa, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Ross Kirsling
2018-02-06 10:22:47 PST
Comment on attachment 333188 [details] Patch Rejecting attachment 333188 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 333188, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: org/git/WebKit 588764ad5db..d90d89507ca master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 228183 = 588764ad5db0553c0876b9ed9429030c7457ab05 r228184 = d90d89507ca5dfcb0a7fd1d7271562255300b10b Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/6385177 Comment on attachment 333188 [details] Patch Attachment 333188 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6385009 New failing tests: media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html Created attachment 333195 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 333201 [details]
Patch
Comment on attachment 333201 [details] Patch Rejecting attachment 333201 [details] from review queue. ross.kirsling@sony.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Created attachment 333202 [details]
Patch for landing
Comment on attachment 333202 [details] Patch for landing Clearing flags on attachment: 333202 Committed r228186: <https://trac.webkit.org/changeset/228186> All reviewed patches have been landed. Closing bug. Oops, sorry about that. |