Bug 182535

Summary: Service workers registrations are saved to disk before the install / activation succeeds
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2018-02-06 09:38:55 PST
Service workers registrations are saved to disk before the install / activation succeeds. This means if the browser exists before the install / activation succeeds, we may restore from disk a registration with an “active” worker which may have never been installed / activated.
Attachments
Patch (2.58 KB, patch)
2018-02-06 09:43 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (2.58 KB, patch)
2018-02-06 10:08 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-02-06 09:39:08 PST
<rdar://problem/36591485>
Chris Dumez
Comment 2 2018-02-06 09:43:07 PST
Created attachment 333182 [details] Patch
youenn fablet
Comment 3 2018-02-06 10:03:39 PST
Comment on attachment 333182 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333182&action=review > Source/WebCore/ChangeLog:10 > + This means if the browser exists before the install / activation succeeds, we may restore s/exists/exits > Source/WebCore/ChangeLog:12 > + activated. Indeed, this is in particular important for service worker doing some cache storage operations only in install step.
Chris Dumez
Comment 4 2018-02-06 10:08:49 PST
Created attachment 333186 [details] Patch
WebKit Commit Bot
Comment 5 2018-02-06 10:43:54 PST
Comment on attachment 333186 [details] Patch Clearing flags on attachment: 333186 Committed r228180: <https://trac.webkit.org/changeset/228180>
WebKit Commit Bot
Comment 6 2018-02-06 10:43:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.