| Summary: | [GTK][WPE] Enable modern media controls | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> |
| Component: | WebKitGTK | Assignee: | Philippe Normand <philn> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, calvaris, lmoura, mcatanzaro, pnormand |
| Priority: | P2 | Keywords: | Gtk |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=214955 https://bugs.webkit.org/show_bug.cgi?id=244378 |
||
|
Description
Zan Dobersek
2018-02-05 12:13:54 PST
They're failing and timing out because we don't use modern media controls. I think the wisest thing here is flag the tests for modern controls and in the case of WPE, it might be interesting to use the GTK+ ones, though I think there could be some theming issues with the iconns that would need to be solved. Either that or we implement those modern controls, which would require contact with GNOME designers, etc. r274810 unskipped the modern-media-control tests alongside other media-related changes and the GTK layout test step was exiting early with many modern-media-controls related issues. I've re-skipped the main folders back in r275010, althouth there are other tests failing related to this. Link to the first failing build: https://build.webkit.org/#/builders/57/builds/772 Pull request: https://github.com/WebKit/WebKit/pull/1147 Committed r295128 (251219@main): <https://commits.webkit.org/251219@main> Reviewed commits have been landed. Closing PR #1147 and removing active labels. |