Bug 182498

Summary: [cmake] Fix build with ICU configured without collation support
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: Tools / TestsAssignee: Konstantin Tokarev <annulen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, lforschler, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review+, commit-queue: commit-queue-

Konstantin Tokarev
Reported 2018-02-05 11:34:51 PST
WebKit has CollatorDefault.cpp providing necessary stubs when UCONFIG_NO_COLLATION is defined, however it is not included in cmake file list.
Attachments
Patch (1.19 KB, patch)
2018-02-05 11:35 PST, Konstantin Tokarev 		achristensen: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2018-02-05 11:35:48 PST
Created attachment 333105 [details] Patch
WebKit Commit Bot
Comment 2 2018-02-05 15:23:55 PST
Comment on attachment 333105 [details] Patch Rejecting attachment 333105 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 333105, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WTF/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/6372244
Konstantin Tokarev
Comment 3 2018-02-05 15:31:34 PST
Committed r228136: <https://trac.webkit.org/changeset/228136>
Radar WebKit Bug Importer
Comment 4 2018-02-05 15:33:28 PST
<rdar://problem/37252550>
Note You need to log in before you can comment on or make changes to this bug.