Bug 182466

Summary: [Cairo] Correctly calculate stride in GraphicsContext3D::paintToCanvas()
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED INVALID    
Severity: Normal CC: dino, ews-watchlist, graouts, kondapallykalyan, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Zan Dobersek 2018-02-04 01:36:49 PST
[Cairo] Correctly calculate stride in GraphicsContext3D::paintToCanvas()
Comment 1 Zan Dobersek 2018-02-04 01:40:44 PST
Created attachment 333049 [details]
Patch
Comment 2 Zan Dobersek 2018-02-04 23:38:11 PST
Comment on attachment 333049 [details]
Patch

Clearing flags on attachment: 333049

Committed r228085: <https://trac.webkit.org/changeset/228085>
Comment 3 Zan Dobersek 2018-02-04 23:38:16 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-02-04 23:39:24 PST
<rdar://problem/37226268>
Comment 5 Zan Dobersek 2018-02-05 02:19:00 PST
Reverted r228085 for reason:

Pixel data stride is imposed by OpenGL and shouldn't be adjusted for Cairo

Committed r228091: <https://trac.webkit.org/changeset/228091>
Comment 6 Zan Dobersek 2018-02-05 02:24:45 PST
(In reply to Zan Dobersek from comment #5)
> Reverted r228085 for reason:
> 
> Pixel data stride is imposed by OpenGL and shouldn't be adjusted for Cairo
> 

I.e., this isn't data we're providing like we do in ImageBufferCairo, but instead it's data that's filled out by OpenGL via glReadPixels(), and that has the prescribed stride that matches width multiplied by 4 bytes (RGBA format, 1 byte per each component).