Bug 182464

Summary: Web Inspector: Styles: completion popover doesn't hide when switching panels
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Animated GIF] Bug
none
Patch none

Description Nikita Vasilyev 2018-02-03 20:13:11 PST
Created attachment 333045 [details]
[Animated GIF] Bug

Steps:
1. Open http://nv.github.io/webkit-inspector-bugs/styles-redesign/tests/commenting-rules.html
2. Inspect the purple square.
3. Add a CSS new property by clicking after ".b {".
4. Type "font".
5. Switch to Computed panel.

Expected:
font's completion popover show hide.

Actual:
font's completion popover stays on screen.
Comment 1 Radar WebKit Bug Importer 2018-02-03 20:13:23 PST
<rdar://problem/37202763>
Comment 2 Nikita Vasilyev 2018-02-03 20:15:24 PST
The legacy styles sidebar has the same bug :(
Comment 3 Nikita Vasilyev 2018-02-05 19:08:27 PST
Created attachment 333147 [details]
Patch

This is one way of fixing the bug. More generic fix would make CompletionSuggestionsView smarter.
Comment 4 WebKit Commit Bot 2018-02-07 11:01:21 PST
Comment on attachment 333147 [details]
Patch

Clearing flags on attachment: 333147

Committed r228232: <https://trac.webkit.org/changeset/228232>
Comment 5 WebKit Commit Bot 2018-02-07 11:01:22 PST
All reviewed patches have been landed.  Closing bug.