Bug 182461

Summary: Web Inspector: Add an experimental setting to enable Sources tab
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
bburg: review+, bburg: commit-queue-
Patch none

Nikita Vasilyev
Reported 2018-02-03 19:07:41 PST
Add a new item to Settings -> Experimental. Sources: [ ] Replace Debugger and Resources tabs with Sources tab <rdar://problem/37201455>
Attachments
Patch (3.74 KB, patch)
2018-02-03 19:13 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (4.23 KB, patch)
2018-02-03 19:27 PST, Nikita Vasilyev 		bburg: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
Patch (4.17 KB, patch)
2018-02-05 12:59 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2018-02-03 19:13:01 PST
Created attachment 333041 [details] Patch
Nikita Vasilyev
Comment 2 2018-02-03 19:27:47 PST
Created attachment 333042 [details] Patch
Blaze Burg
Comment 3 2018-02-05 11:39:58 PST
Comment on attachment 333042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333042&action=review r=me > Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:253 > + experimentalSettingsView.addSetting(WI.UIString("Sources:"), WI.settings.experimentalEnableSourcesTab, WI.UIString("Replace Debugger and Resources tabs with Sources tab")); Please just call it "Enable Sources Tab".
Nikita Vasilyev
Comment 4 2018-02-05 12:59:36 PST
Created attachment 333113 [details] Patch
WebKit Commit Bot
Comment 5 2018-02-05 14:37:57 PST
Comment on attachment 333113 [details] Patch Clearing flags on attachment: 333113 Committed r228129: <https://trac.webkit.org/changeset/228129>
WebKit Commit Bot
Comment 6 2018-02-05 14:37:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.