Bug 182461

Summary: Web Inspector: Add an experimental setting to enable Sources tab
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
bburg: review+, bburg: commit-queue-
Patch none

Description Nikita Vasilyev 2018-02-03 19:07:41 PST
Add a new item to Settings -> Experimental.

    Sources: [ ] Replace Debugger and Resources tabs with Sources tab

<rdar://problem/37201455>
Comment 1 Nikita Vasilyev 2018-02-03 19:13:01 PST
Created attachment 333041 [details]
Patch
Comment 2 Nikita Vasilyev 2018-02-03 19:27:47 PST
Created attachment 333042 [details]
Patch
Comment 3 BJ Burg 2018-02-05 11:39:58 PST
Comment on attachment 333042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333042&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:253
> +        experimentalSettingsView.addSetting(WI.UIString("Sources:"), WI.settings.experimentalEnableSourcesTab, WI.UIString("Replace Debugger and Resources tabs with Sources tab"));

Please just call it "Enable Sources Tab".
Comment 4 Nikita Vasilyev 2018-02-05 12:59:36 PST
Created attachment 333113 [details]
Patch
Comment 5 WebKit Commit Bot 2018-02-05 14:37:57 PST
Comment on attachment 333113 [details]
Patch

Clearing flags on attachment: 333113

Committed r228129: <https://trac.webkit.org/changeset/228129>
Comment 6 WebKit Commit Bot 2018-02-05 14:37:58 PST
All reviewed patches have been landed.  Closing bug.