Bug 182455

Summary: Improve NetworkResourceLoader logging so it can be used for 'setCookiesFromDOM'
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing bfulgham: commit-queue+

Brent Fulgham
Reported 2018-02-02 16:53:03 PST
The diagnostic logging code handles cookies set by resource loads, but it doesn't log activity generated in script. This patch revises the NetworkResourceLoader logging code so that it can be used for the 'setCookiesFromDOM' case.
Attachments
Patch (16.53 KB, patch)
2018-02-02 17:14 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (18.58 KB, patch)
2018-02-05 10:29 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.74 KB, patch)
2018-02-05 10:41 PST, Brent Fulgham 		bfulgham: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2018-02-02 16:53:25 PST
<rdar://problem/36626601>
Brent Fulgham
Comment 2 2018-02-02 17:14:27 PST
Created attachment 333020 [details] Patch
Brent Fulgham
Comment 3 2018-02-05 10:29:12 PST
Created attachment 333093 [details] Patch
Chris Dumez
Comment 4 2018-02-05 10:32:57 PST
Comment on attachment 333093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333093&action=review r=me with comment > Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:713 > +bool NetworkResourceLoader::shouldLogCookieInformation() Why did you drop the const? Seems like a method that should be const.
Brent Fulgham
Comment 5 2018-02-05 10:41:25 PST
Created attachment 333095 [details] Patch for landing
Brent Fulgham
Comment 6 2018-02-05 10:42:02 PST
Comment on attachment 333093 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333093&action=review >> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:713 >> +bool NetworkResourceLoader::shouldLogCookieInformation() > > Why did you drop the const? Seems like a method that should be const. I made this a static method on the object, so it cannot be const anymore.
Brent Fulgham
Comment 7 2018-02-05 10:42:34 PST
Note: The patch failed to build on iOS because the new logging was not guarded by the RELEASE_LOG_DISABLED macro. I've fixed that in the patch for landing.
Brent Fulgham
Comment 8 2018-02-05 12:03:50 PST
Committed r228111: <https://trac.webkit.org/changeset/228111>
Note You need to log in before you can comment on or make changes to this bug.