Bug 182455

Summary: Improve NetworkResourceLoader logging so it can be used for 'setCookiesFromDOM'
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing bfulgham: commit-queue+

Description Brent Fulgham 2018-02-02 16:53:03 PST 
The diagnostic logging code handles cookies set by resource loads, but it doesn't log activity generated in script.

This patch revises the NetworkResourceLoader logging code so that it can be used for the 'setCookiesFromDOM' case.
Comment 1 Brent Fulgham 2018-02-02 16:53:25 PST 
<rdar://problem/36626601>
Comment 2 Brent Fulgham 2018-02-02 17:14:27 PST 
Created attachment 333020 [details]
Patch
Comment 3 Brent Fulgham 2018-02-05 10:29:12 PST 
Created attachment 333093 [details]
Patch
Comment 4 Chris Dumez 2018-02-05 10:32:57 PST 
Comment on attachment 333093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333093&action=review

r=me with comment

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:713
> +bool NetworkResourceLoader::shouldLogCookieInformation()

Why did you drop the const? Seems like a method that should be const.
Comment 5 Brent Fulgham 2018-02-05 10:41:25 PST 
Created attachment 333095 [details]
Patch for landing
Comment 6 Brent Fulgham 2018-02-05 10:42:02 PST 
Comment on attachment 333093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333093&action=review

>> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:713
>> +bool NetworkResourceLoader::shouldLogCookieInformation()
> 
> Why did you drop the const? Seems like a method that should be const.

I made this a static method on the object, so it cannot be const anymore.
Comment 7 Brent Fulgham 2018-02-05 10:42:34 PST 
Note: The patch failed to build on iOS because the new logging was not guarded by the RELEASE_LOG_DISABLED macro. I've fixed that in the patch for landing.
Comment 8 Brent Fulgham 2018-02-05 12:03:50 PST 
Committed r228111: <https://trac.webkit.org/changeset/228111>