Bug 182453

Summary: Make various DFG_ASSERTs provide more data to WTFCrashWithInfo
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
jfbastien: review+
patch for landing none

Saam Barati
Reported 2018-02-02 15:16:45 PST
Should help us when looking at the register file of a crashlog.
Attachments
patch (36.39 KB, patch)
2018-02-02 16:06 PST, Saam Barati 		jfbastien: review+
DetailsFormatted DiffDiff
patch for landing (35.83 KB, patch)
2018-02-02 16:12 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-02-02 16:03:48 PST
<rdar://problem/37174236>
Saam Barati
Comment 2 2018-02-02 16:06:25 PST
Created attachment 333015 [details] patch
JF Bastien
Comment 3 2018-02-02 16:08:34 PST
Comment on attachment 333015 [details] patch r=me
Mark Lam
Comment 4 2018-02-02 16:10:07 PST
Comment on attachment 333015 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=333015&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:13057 > + DFG_ASSERT(m_graph, m_node, characterCases[i - 1].character < characterCases[i].character, characterCases[i - 1].character, characterCases[i].character); Is this an information leak in terms of privacy of the user? Given that it's just 2 characters, I think it's safe.
Saam Barati
Comment 5 2018-02-02 16:10:33 PST
(In reply to Mark Lam from comment #4) > Comment on attachment 333015 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=333015&action=review > > r=me > > > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:13057 > > + DFG_ASSERT(m_graph, m_node, characterCases[i - 1].character < characterCases[i].character, characterCases[i - 1].character, characterCases[i].character); > > Is this an information leak in terms of privacy of the user? Given that > it's just 2 characters, I think it's safe. Don't know, but let's not risk it. I'll remove it.
Saam Barati
Comment 6 2018-02-02 16:12:21 PST
Created attachment 333017 [details] patch for landing
WebKit Commit Bot
Comment 7 2018-02-02 16:43:19 PST
Comment on attachment 333017 [details] patch for landing Clearing flags on attachment: 333017 Committed r228035: <https://trac.webkit.org/changeset/228035>
WebKit Commit Bot
Comment 8 2018-02-02 16:43:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.