Bug 182452

Summary: JavaScriptCore files should not be included relatively
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: JavaScriptCoreAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 182347    
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2018-02-02 14:59:08 PST
Within JavaScript core there are files that #include based on a relative path.
Attachments
Patch (10.76 KB, patch)
2018-02-02 15:02 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-02-02 15:02:02 PST
Created attachment 333006 [details] Patch This removes all relative includes within JavaScriptCore headers. There are explicit includes of <JavaScriptCore/Foo.h> within Source/JavaScriptCore/API that might be able to be removed at a later time. Its not clear if they would affect the Apple build or not with how frameworks are built. This should be revisited if CMake ports arrange their headers like Cocoa frameworks.
Keith Miller
Comment 2 2018-02-05 10:36:54 PST
Comment on attachment 333006 [details] Patch r=me.
WebKit Commit Bot
Comment 3 2018-02-05 11:02:11 PST
Comment on attachment 333006 [details] Patch Clearing flags on attachment: 333006 Committed r228105: <https://trac.webkit.org/changeset/228105>
WebKit Commit Bot
Comment 4 2018-02-05 11:02:13 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-02-05 11:04:13 PST
<rdar://problem/37243387>
Note You need to log in before you can comment on or make changes to this bug.