| Summary: | JavaScriptCore files should not be included relatively | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
| Component: | JavaScriptCore | Assignee: | Don Olmstead <don.olmstead> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, annulen, commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 182347 | ||||||
| Attachments: |
|
||||||
|
Description
Don Olmstead
2018-02-02 14:59:08 PST
Created attachment 333006 [details]
Patch
This removes all relative includes within JavaScriptCore headers.
There are explicit includes of <JavaScriptCore/Foo.h> within Source/JavaScriptCore/API that might be able to be removed at a later time. Its not clear if they would affect the Apple build or not with how frameworks are built. This should be revisited if CMake ports arrange their headers like Cocoa frameworks.
Comment on attachment 333006 [details]
Patch
r=me.
Comment on attachment 333006 [details] Patch Clearing flags on attachment: 333006 Committed r228105: <https://trac.webkit.org/changeset/228105> All reviewed patches have been landed. Closing bug. |