Summary: | WebCore code generators should include JavaScriptCore headers directly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||
Component: | WebCore Misc. | Assignee: | Don Olmstead <don.olmstead> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, darin, fpizlo, ggaren, joepeck, keith_miller, rniwa, saam, sam, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 182347 | ||||||
Attachments: |
|
Description
Don Olmstead
2018-02-02 12:58:26 PST
Created attachment 332996 [details]
Patch
Modified all includes to not target ForwardingHeaders. Tests were rebaselined.
Comment on attachment 332996 [details]
Patch
Seems reasonable to me, but I'll leave the r+/comments for someone more experienced in the bindings generator
Comment on attachment 332996 [details] Patch Clearing flags on attachment: 332996 Committed r228038: <https://trac.webkit.org/changeset/228038> All reviewed patches have been landed. Closing bug. It looks like this landed but it didn't actually remove the ForwardingHeaders directory. Can that directory be removed? =) (In reply to Joseph Pecoraro from comment #6) > It looks like this landed but it didn't actually remove the > ForwardingHeaders directory. Can that directory be removed? =) Oop, I thought this was the parent bug (because thats the link I clicked in my email)! Carry on! |