Bug 182445

Summary: JS Builtins should include JavaScriptCore headers directly
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: JavaScriptCoreAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, ryanhaddad, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 182347    
Attachments:
Description Flags
Patch
ysuzuki: review+
Patch none

Don Olmstead
Reported 2018-02-02 11:56:34 PST
Currently generate-js-builtins.py --framework WebCore generates includes that target the ForwardingHeaders directory rather than JavaScriptCore directly.
Attachments
Patch (12.19 KB, patch)
2018-02-02 11:58 PST, Don Olmstead 		ysuzuki: review+
DetailsFormatted DiffDiff
Patch (11.45 KB, patch)
2018-02-02 12:41 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-02-02 11:58:09 PST
Created attachment 332988 [details] Patch Modifies the generator to output <JavaScriptCore/Foo.h> includes and updates the test expectations accordingly.
EWS Watchlist
Comment 2 2018-02-02 12:00:55 PST
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
Yusuke Suzuki
Comment 3 2018-02-02 12:30:44 PST
Comment on attachment 332988 [details] Patch r=me if all EWS gets green.
Mark Lam
Comment 4 2018-02-02 12:33:37 PST
Comment on attachment 332988 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332988&action=review > Source/JavaScriptCore/ChangeLog:12 > + (BuiltinsGenerator.model): Deleted. > + (BuiltinsGenerator.generate_output): Deleted. > + (BuiltinsGenerator.output_filename): Deleted. > + (BuiltinsGenerator.generate_license): Deleted. I don't see these changes in the diff below. Are these for real? > Source/JavaScriptCore/ChangeLog:20 > + (BuiltinsGenerator.generate_primary_header_includes): Deleted. > + (BuiltinsGenerator.generate_embedded_code_string_section_for_function): Deleted. > + (BuiltinsGenerator.wrap_with_guard): Deleted. > + (BuiltinsGenerator.mangledNameForObject): Deleted. > + (BuiltinsGenerator.mangledNameForObject.toCamel): Deleted. > + (BuiltinsGenerator.mangledNameForFunction): Deleted. > + (BuiltinsGenerator.mangledNameForFunction.toCamel): Deleted. Ditto.
Don Olmstead
Comment 5 2018-02-02 12:36:15 PST
(In reply to Mark Lam from comment #4) > Comment on attachment 332988 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332988&action=review > > > Source/JavaScriptCore/ChangeLog:12 > > + (BuiltinsGenerator.model): Deleted. > > + (BuiltinsGenerator.generate_output): Deleted. > > + (BuiltinsGenerator.output_filename): Deleted. > > + (BuiltinsGenerator.generate_license): Deleted. > > I don't see these changes in the diff below. Are these for real? > > > Source/JavaScriptCore/ChangeLog:20 > > + (BuiltinsGenerator.generate_primary_header_includes): Deleted. > > + (BuiltinsGenerator.generate_embedded_code_string_section_for_function): Deleted. > > + (BuiltinsGenerator.wrap_with_guard): Deleted. > > + (BuiltinsGenerator.mangledNameForObject): Deleted. > > + (BuiltinsGenerator.mangledNameForObject.toCamel): Deleted. > > + (BuiltinsGenerator.mangledNameForFunction): Deleted. > > + (BuiltinsGenerator.mangledNameForFunction.toCamel): Deleted. > > Ditto. I'll go ahead and fix up the Changelog.
Don Olmstead
Comment 6 2018-02-02 12:41:02 PST
Created attachment 332994 [details] Patch Fix the Changelog up manually
WebKit Commit Bot
Comment 7 2018-02-02 15:37:16 PST
Comment on attachment 332994 [details] Patch Clearing flags on attachment: 332994 Committed r228032: <https://trac.webkit.org/changeset/228032>
WebKit Commit Bot
Comment 8 2018-02-02 15:37:17 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-02-02 15:38:37 PST
<rdar://problem/37173468>
Ryan Haddad
Comment 10 2018-02-02 17:39:33 PST
Rebaselined bindings generator tests in https://trac.webkit.org/r228040
Note You need to log in before you can comment on or make changes to this bug.