Bug 182441

Summary: More ARM64_32 fixes.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, keith_miller, mitz, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
mitz: review+
patch for landing. none

Mark Lam
Reported 2018-02-02 10:58:38 PST
My previous speculative ARM64_32 build fix in copyLCharsFromUCharSource() was wrong. I've now fixed it to use choose the default case instead of the ARM64 case if the target is ARM64_32. I also disabled more dynamicPoisoning code in ARM64_32. This code assumes a 64-bit pointer which is not applicable here.
Attachments
proposed patch. (4.26 KB, patch)
2018-02-02 11:06 PST, Mark Lam 		mitz: review+
DetailsFormatted DiffDiff
patch for landing. (4.29 KB, patch)
2018-02-02 11:16 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-02-02 11:00:43 PST
<rdar://problem/37162310>
Mark Lam
Comment 2 2018-02-02 11:06:36 PST
Created attachment 332982 [details] proposed patch.
Mark Lam
Comment 3 2018-02-02 11:16:54 PST
Created attachment 332985 [details] patch for landing.
Mark Lam
Comment 4 2018-02-02 12:25:21 PST
Thanks for the review. Landed in r228022: <http://trac.webkit.org/r228022>.
Note You need to log in before you can comment on or make changes to this bug.