Bug 182415

Summary: Make MallocBench easier for non-WebKit engineers to run
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, joepeck, rniwa, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Geoffrey Garen
Reported 2018-02-01 17:10:56 PST
Make MallocBench easier for non-WebKit engineers to run
Attachments
Patch (8.63 KB, patch)
2018-02-01 17:33 PST, Geoffrey Garen 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2018-02-01 17:33:25 PST
Created attachment 332925 [details] Patch
Saam Barati
Comment 2 2018-02-01 17:37:51 PST
Comment on attachment 332925 [details] Patch r=me
Joseph Pecoraro
Comment 3 2018-02-01 19:14:10 PST
Comment on attachment 332925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332925&action=review Looks good to me too. > PerformanceTests/MallocBench/run-malloc-benchmarks:259 > + name = arg.split(":")[0] > + path = arg.split(":")[1] You can write this in a way that avoids split twice: name, path = arg.split(":")
Geoffrey Garen
Comment 4 2018-02-02 12:30:25 PST
Committed r228023: <https://trac.webkit.org/changeset/228023>
Radar WebKit Bug Importer
Comment 5 2018-02-02 12:31:31 PST
<rdar://problem/37166033>
Note You need to log in before you can comment on or make changes to this bug.