Bug 182415

Summary: Make MallocBench easier for non-WebKit engineers to run
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, joepeck, rniwa, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Description Geoffrey Garen 2018-02-01 17:10:56 PST
Make MallocBench easier for non-WebKit engineers to run
Comment 1 Geoffrey Garen 2018-02-01 17:33:25 PST
Created attachment 332925 [details]
Patch
Comment 2 Saam Barati 2018-02-01 17:37:51 PST
Comment on attachment 332925 [details]
Patch

r=me
Comment 3 Joseph Pecoraro 2018-02-01 19:14:10 PST
Comment on attachment 332925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332925&action=review

Looks good to me too.

> PerformanceTests/MallocBench/run-malloc-benchmarks:259
> +        name = arg.split(":")[0]
> +        path = arg.split(":")[1]

You can write this in a way that avoids split twice:

    name, path = arg.split(":")
Comment 4 Geoffrey Garen 2018-02-02 12:30:25 PST
Committed r228023: <https://trac.webkit.org/changeset/228023>
Comment 5 Radar WebKit Bug Importer 2018-02-02 12:31:31 PST
<rdar://problem/37166033>