| Summary: | Form submission after navigation fails when decidePolicyForNavigationAction is async | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||||||||||||
| Component: | New Bugs | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | aestes, beidson, cdumez, commit-queue, dbates, ews-watchlist, japhet, rniwa, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=180568 | ||||||||||||||||||||
| Bug Depends on: | 182697 | ||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Alex Christensen
2018-02-01 16:43:00 PST
Created attachment 332923 [details]
Patch
Comment on attachment 332923 [details] Patch Initial patch just contains failing test for rdar://problem/35181099 Created attachment 333000 [details]
Patch
Comment on attachment 333000 [details]
Patch
As discussed in person, this still has changed WK API behavior.
Comment on attachment 333000 [details] Patch Attachment 333000 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6337129 Number of test failures exceeded the failure limit. Created attachment 333005 [details]
Archive of layout-test-results from ews102 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 333000 [details] Patch Attachment 333000 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6337119 Number of test failures exceeded the failure limit. Created attachment 333007 [details]
Archive of layout-test-results from ews113 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 333009 [details]
Patch
Comment on attachment 333009 [details] Patch Attachment 333009 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6337744 Number of test failures exceeded the failure limit. Created attachment 333010 [details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 333009 [details] Patch Attachment 333009 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6337743 Number of test failures exceeded the failure limit. Created attachment 333013 [details]
Archive of layout-test-results from ews112 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Chris, the three WPT test failures in my latest patch are definitely related to why this bug is happening. If you make TestController::decidePolicyForNavigationAction always dispatch on the run loop, you'll be able to investigate them. I think fixing this will take adding a queue of some sort to the FrameLoader. Created attachment 333421 [details]
Patch
Seems to pass the tests locally and fix the bug. Let's see how EWS likes it. Comment on attachment 333421 [details]
Patch
API tests locally look happy. Mac-EWS as well.
Comment on attachment 333421 [details] Patch Clearing flags on attachment: 333421 Committed r228299: <https://trac.webkit.org/changeset/228299> All reviewed patches have been landed. Closing bug. |