Bug 182408 – Improve NetworkResourceLogger to report blocked (versus non-partitioned) cookies

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Brent Fulgham]

Our debug logging is not including the results for some resource loads because they are being blocked (not just partitioned).

Revise the logging so that blocked loads are properly captured for testing.

[Brent Fulgham]

Created attachment 332915 [details]
Patch

[Chris Dumez]

Comment on attachment 332915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332915&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:720
>      auto networkStorageSession = WebCore::NetworkStorageSession::storageSession(sessionID());

Could you please add an ASSERT(shouldLogCookieInformation()); at the beginning of this method?

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:727
> +        s.replace('\\', "\\\\").replace('"', "\\\"");

return s.replace('\\', "\\\\").replace('"', "\\\"");

[Brent Fulgham]

Comment on attachment 332915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332915&action=review

>> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:720
>>      auto networkStorageSession = WebCore::NetworkStorageSession::storageSession(sessionID());
> 
> Could you please add an ASSERT(shouldLogCookieInformation()); at the beginning of this method?

Will do!

>> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:727
>> +        s.replace('\\', "\\\\").replace('"', "\\\"");
> 
> return s.replace('\\', "\\\\").replace('"', "\\\"");

Will do.

[Brent Fulgham]

Created attachment 332917 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 332917 [details]
Patch for landing

Clearing flags on attachment: 332917

Committed r227991: <https://trac.webkit.org/changeset/227991>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.