Bug 182408

Summary: Improve NetworkResourceLogger to report blocked (versus non-partitioned) cookies
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, krollin
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Brent Fulgham 2018-02-01 15:24:42 PST
Our debug logging is not including the results for some resource loads because they are being blocked (not just partitioned).

Revise the logging so that blocked loads are properly captured for testing.
Comment 1 Brent Fulgham 2018-02-01 15:29:37 PST
Created attachment 332915 [details]
Patch
Comment 2 Chris Dumez 2018-02-01 15:42:46 PST
Comment on attachment 332915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332915&action=review

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:720
>      auto networkStorageSession = WebCore::NetworkStorageSession::storageSession(sessionID());

Could you please add an ASSERT(shouldLogCookieInformation()); at the beginning of this method?

> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:727
> +        s.replace('\\', "\\\\").replace('"', "\\\"");

return s.replace('\\', "\\\\").replace('"', "\\\"");
Comment 3 Brent Fulgham 2018-02-01 15:44:48 PST
Comment on attachment 332915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332915&action=review

>> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:720
>>      auto networkStorageSession = WebCore::NetworkStorageSession::storageSession(sessionID());
> 
> Could you please add an ASSERT(shouldLogCookieInformation()); at the beginning of this method?

Will do!

>> Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:727
>> +        s.replace('\\', "\\\\").replace('"', "\\\"");
> 
> return s.replace('\\', "\\\\").replace('"', "\\\"");

Will do.
Comment 4 Brent Fulgham 2018-02-01 15:45:46 PST
Created attachment 332917 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-02-01 16:54:48 PST
Comment on attachment 332917 [details]
Patch for landing

Clearing flags on attachment: 332917

Committed r227991: <https://trac.webkit.org/changeset/227991>
Comment 6 WebKit Commit Bot 2018-02-01 16:54:50 PST
All reviewed patches have been landed.  Closing bug.