Summary: | Clearing all service worker registrations should wait for importing service worker registration to finish | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | beidson, cdumez, commit-queue, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
youenn fablet
2018-02-01 14:58:19 PST
Created attachment 332911 [details]
Patch
Comment on attachment 332911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332911&action=review > Source/WebCore/workers/service/server/SWServer.cpp:187 > +void SWServer::clearAll(CompletionHandler<void()>&& completionHandler) 2 concerns: - what about clear(origin)? - I do not see why we could not get several clearAll() requests consecutively, in which case, you would keep overwriting m_clearAllCompletionHandler. Created attachment 332928 [details]
Patch
Comment on attachment 332928 [details] Patch Clearing flags on attachment: 332928 Committed r228025: <https://trac.webkit.org/changeset/228025> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 333012 [details]
Follow-up fix
Comment on attachment 333012 [details] Follow-up fix Clearing flags on attachment: 333012 Committed r228034: <https://trac.webkit.org/changeset/228034> All reviewed patches have been landed. Closing bug. |