Bug 182407

Summary: Clearing all service worker registrations should wait for importing service worker registration to finish
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Severity: Normal CC: beidson, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Follow-up fix none

Description youenn fablet 2018-02-01 14:58:19 PST
Otherwise, there might be some left over.
Comment 1 youenn fablet 2018-02-01 14:59:39 PST
Created attachment 332911 [details]
Comment 2 Chris Dumez 2018-02-01 15:06:31 PST
Comment on attachment 332911 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=332911&action=review

> Source/WebCore/workers/service/server/SWServer.cpp:187
> +void SWServer::clearAll(CompletionHandler<void()>&& completionHandler)

2 concerns:
- what about clear(origin)?
- I do not see why we could not get several clearAll() requests consecutively, in which case, you would keep overwriting m_clearAllCompletionHandler.
Comment 3 youenn fablet 2018-02-01 18:09:53 PST
Created attachment 332928 [details]
Comment 4 WebKit Commit Bot 2018-02-02 13:09:02 PST
Comment on attachment 332928 [details]

Clearing flags on attachment: 332928

Committed r228025: <https://trac.webkit.org/changeset/228025>
Comment 5 WebKit Commit Bot 2018-02-02 13:09:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-02-02 13:11:01 PST
Comment 7 youenn fablet 2018-02-02 15:51:44 PST
Reopening to attach new patch.
Comment 8 youenn fablet 2018-02-02 15:51:45 PST
Created attachment 333012 [details]
Follow-up fix
Comment 9 WebKit Commit Bot 2018-02-02 16:39:36 PST
Comment on attachment 333012 [details]
Follow-up fix

Clearing flags on attachment: 333012

Committed r228034: <https://trac.webkit.org/changeset/228034>
Comment 10 WebKit Commit Bot 2018-02-02 16:39:38 PST
All reviewed patches have been landed.  Closing bug.