Bug 182407

Summary: Clearing all service worker registrations should wait for importing service worker registration to finish
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Follow-up fix none

youenn fablet
Reported 2018-02-01 14:58:19 PST
Otherwise, there might be some left over.
Attachments
Patch (2.77 KB, patch)
2018-02-01 14:59 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (12.33 KB, patch)
2018-02-01 18:09 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Follow-up fix (1.66 KB, patch)
2018-02-02 15:51 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-02-01 14:59:39 PST
Created attachment 332911 [details] Patch
Chris Dumez
Comment 2 2018-02-01 15:06:31 PST
Comment on attachment 332911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332911&action=review > Source/WebCore/workers/service/server/SWServer.cpp:187 > +void SWServer::clearAll(CompletionHandler<void()>&& completionHandler) 2 concerns: - what about clear(origin)? - I do not see why we could not get several clearAll() requests consecutively, in which case, you would keep overwriting m_clearAllCompletionHandler.
youenn fablet
Comment 3 2018-02-01 18:09:53 PST
Created attachment 332928 [details] Patch
WebKit Commit Bot
Comment 4 2018-02-02 13:09:02 PST
Comment on attachment 332928 [details] Patch Clearing flags on attachment: 332928 Committed r228025: <https://trac.webkit.org/changeset/228025>
WebKit Commit Bot
Comment 5 2018-02-02 13:09:03 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-02-02 13:11:01 PST
<rdar://problem/37167523>
youenn fablet
Comment 7 2018-02-02 15:51:44 PST
Reopening to attach new patch.
youenn fablet
Comment 8 2018-02-02 15:51:45 PST
Created attachment 333012 [details] Follow-up fix
WebKit Commit Bot
Comment 9 2018-02-02 16:39:36 PST
Comment on attachment 333012 [details] Follow-up fix Clearing flags on attachment: 333012 Committed r228034: <https://trac.webkit.org/changeset/228034>
WebKit Commit Bot
Comment 10 2018-02-02 16:39:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.