Bug 182402

Summary:

MapHash should return true to doesGC in the DFG depending on useKind because it might resolve a rope

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Saam Barati 2018-02-01 12:37:07 PST

It may resolve a rope.

Comment 1 Yusuke Suzuki 2018-02-01 22:20:24 PST

I think we can return false for doesGC if MapHash with several edges like Int32Use.

Comment 2 Saam Barati 2018-02-02 09:31:42 PST

Created attachment 332976 [details]
patch

Comment 3 Yusuke Suzuki 2018-02-02 09:34:10 PST

Comment on attachment 332976 [details]
patch

r=me

Comment 4 WebKit Commit Bot 2018-02-02 11:07:35 PST

Comment on attachment 332976 [details]
patch

Clearing flags on attachment: 332976

Committed r228018: <https://trac.webkit.org/changeset/228018>

Comment 5 WebKit Commit Bot 2018-02-02 11:07:37 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2018-02-02 11:08:24 PST

<rdar://problem/37162616>