Bug 182402

Summary: MapHash should return true to doesGC in the DFG depending on useKind because it might resolve a rope
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2018-02-01 12:37:07 PST
It may resolve a rope.
Attachments
patch (1.58 KB, patch)
2018-02-02 09:31 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-02-01 22:20:24 PST
I think we can return false for doesGC if MapHash with several edges like Int32Use.
Saam Barati
Comment 2 2018-02-02 09:31:42 PST
Created attachment 332976 [details] patch
Yusuke Suzuki
Comment 3 2018-02-02 09:34:10 PST
Comment on attachment 332976 [details] patch r=me
WebKit Commit Bot
Comment 4 2018-02-02 11:07:35 PST
Comment on attachment 332976 [details] patch Clearing flags on attachment: 332976 Committed r228018: <https://trac.webkit.org/changeset/228018>
WebKit Commit Bot
Comment 5 2018-02-02 11:07:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-02-02 11:08:24 PST
<rdar://problem/37162616>
Note You need to log in before you can comment on or make changes to this bug.