Bug 182402 - MapHash should return true to doesGC in the DFG depending on useKind because it might resolve a rope
Summary: MapHash should return true to doesGC in the DFG depending on useKind because ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-01 12:37 PST by Saam Barati
Modified: 2018-02-02 11:08 PST (History)
13 users (show)

See Also:

Attachments
patch (1.58 KB, patch)
2018-02-02 09:31 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-02-01 12:37:07 PST 
It may resolve a rope.
Comment 1 Yusuke Suzuki 2018-02-01 22:20:24 PST 
I think we can return false for doesGC if MapHash with several edges like Int32Use.
Comment 2 Saam Barati 2018-02-02 09:31:42 PST 
Created attachment 332976 [details]
patch
Comment 3 Yusuke Suzuki 2018-02-02 09:34:10 PST 
Comment on attachment 332976 [details]
patch

r=me
Comment 4 WebKit Commit Bot 2018-02-02 11:07:35 PST 
Comment on attachment 332976 [details]
patch

Clearing flags on attachment: 332976

Committed r228018: <https://trac.webkit.org/changeset/228018>
Comment 5 WebKit Commit Bot 2018-02-02 11:07:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-02-02 11:08:24 PST 
<rdar://problem/37162616>