Bug 182392

Summary:

Add missing RETURN_IF_EXCEPTION() after object->get() calls in convertDictionary<>()

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, darin, ews-watchlist, ggaren, mark.lam, rniwa, sam, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews102 for mac-sierra	none
Patch	none

Chris Dumez

Reported 2018-02-01 09:40:01 PST

Add missing RETURN_IF_EXCEPTION() after object->get() calls in convertDictionary<>().

Attachments
WIP Patch (36.54 KB, patch) 2018-02-01 09:45 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.79 MB, application/zip) 2018-02-01 10:38 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews102 for mac-sierra (2.36 MB, application/zip) 2018-02-01 10:50 PST, EWS Watchlist	no flags	Details
Patch (62.22 KB, patch) 2018-02-01 10:55 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-02-01 09:40:59 PST

<rdar://problem/37119215>

Chris Dumez

Comment 2 2018-02-01 09:45:06 PST

Created attachment 332885 [details] WIP Patch

EWS Watchlist

Comment 3 2018-02-01 10:38:44 PST

Comment on attachment 332885 [details] WIP Patch Attachment 332885 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6318268 New failing tests: fast/events/constructors/message-event-constructor.html

EWS Watchlist

Comment 4 2018-02-01 10:38:45 PST

Created attachment 332889 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-02-01 10:50:19 PST

Comment on attachment 332885 [details] WIP Patch Attachment 332885 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6318334 New failing tests: fast/events/constructors/message-event-constructor.html

EWS Watchlist

Comment 6 2018-02-01 10:50:20 PST

Created attachment 332891 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

Chris Dumez

Comment 7 2018-02-01 10:55:51 PST

Created attachment 332892 [details] Patch

Geoffrey Garen

Comment 8 2018-02-01 15:21:45 PST

Comment on attachment 332892 [details] Patch r=me

WebKit Commit Bot

Comment 9 2018-02-01 15:33:23 PST

Comment on attachment 332892 [details] Patch Clearing flags on attachment: 332892 Committed r227985: <https://trac.webkit.org/changeset/227985>

WebKit Commit Bot

Comment 10 2018-02-01 15:33:25 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.