Bug 182392 - Add missing RETURN_IF_EXCEPTION() after object->get() calls in convertDictionary<>()
Summary: Add missing RETURN_IF_EXCEPTION() after object->get() calls in convertDiction...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-02-01 09:40 PST by Chris Dumez
Modified: 2018-02-01 15:33 PST (History)
10 users (show)

See Also:


Attachments
WIP Patch (36.54 KB, patch)
2018-02-01 09:45 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.79 MB, application/zip)
2018-02-01 10:38 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews102 for mac-sierra (2.36 MB, application/zip)
2018-02-01 10:50 PST, EWS Watchlist
no flags Details
Patch (62.22 KB, patch)
2018-02-01 10:55 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-02-01 09:40:01 PST
Add missing RETURN_IF_EXCEPTION() after object->get() calls in convertDictionary<>().
Comment 1 Radar WebKit Bug Importer 2018-02-01 09:40:59 PST
<rdar://problem/37119215>
Comment 2 Chris Dumez 2018-02-01 09:45:06 PST
Created attachment 332885 [details]
WIP Patch
Comment 3 EWS Watchlist 2018-02-01 10:38:44 PST
Comment on attachment 332885 [details]
WIP Patch

Attachment 332885 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6318268

New failing tests:
fast/events/constructors/message-event-constructor.html
Comment 4 EWS Watchlist 2018-02-01 10:38:45 PST
Created attachment 332889 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-02-01 10:50:19 PST
Comment on attachment 332885 [details]
WIP Patch

Attachment 332885 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6318334

New failing tests:
fast/events/constructors/message-event-constructor.html
Comment 6 EWS Watchlist 2018-02-01 10:50:20 PST
Created attachment 332891 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 Chris Dumez 2018-02-01 10:55:51 PST
Created attachment 332892 [details]
Patch
Comment 8 Geoffrey Garen 2018-02-01 15:21:45 PST
Comment on attachment 332892 [details]
Patch

r=me
Comment 9 WebKit Commit Bot 2018-02-01 15:33:23 PST
Comment on attachment 332892 [details]
Patch

Clearing flags on attachment: 332892

Committed r227985: <https://trac.webkit.org/changeset/227985>
Comment 10 WebKit Commit Bot 2018-02-01 15:33:25 PST
All reviewed patches have been landed.  Closing bug.