Bug 182372

Summary: Queue a microtask when a waitUntil() promise is settled
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, ews-watchlist, ggaren, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://w3c.github.io/ServiceWorker/#dom-extendableevent-waituntil
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews106 for mac-sierra-wk2 none

Chris Dumez
Reported 2018-01-31 20:11:24 PST
Queue a microtask when a waitUntil() promise is settled, as per: - https://w3c.github.io/ServiceWorker/#dom-extendableevent-waituntil (step 5) Otherwise, we decrement m_pendingPromiseCount too quickly and it may cause following calls to waitUntil() to throw when they shouldn't.
Attachments
Patch (8.09 KB, patch)
2018-01-31 20:43 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.61 MB, application/zip)
2018-01-31 21:58 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-31 20:11:51 PST
<rdar://problem/37101019>
Chris Dumez
Comment 2 2018-01-31 20:43:01 PST
Created attachment 332844 [details] Patch
Mark Lam
Comment 3 2018-01-31 20:57:57 PST
Comment on attachment 332844 [details] Patch r=me
EWS Watchlist
Comment 4 2018-01-31 21:58:53 PST
Comment on attachment 332844 [details] Patch Attachment 332844 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6310810 New failing tests: js/regexp-unicode.html
EWS Watchlist
Comment 5 2018-01-31 21:58:54 PST
Created attachment 332848 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
WebKit Commit Bot
Comment 6 2018-02-01 03:50:52 PST
Comment on attachment 332844 [details] Patch Clearing flags on attachment: 332844 Committed r227959: <https://trac.webkit.org/changeset/227959>
WebKit Commit Bot
Comment 7 2018-02-01 03:50:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.