Bug 182362

Summary: Use different debug red colors for different contexts
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2018-01-31 16:47:38 PST
Use different debug red colors for different contexts
Attachments
Patch (4.52 KB, patch)
2018-01-31 16:49 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (4.39 KB, patch)
2018-01-31 16:55 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-01-31 16:49:48 PST
Created attachment 332823 [details] Patch
Tim Horton
Comment 2 2018-01-31 16:54:10 PST
Comment on attachment 332823 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332823&action=review > Source/WebCore/page/FrameView.cpp:4023 > - if (!renderView) { > + if (renderView) { !?
Simon Fraser (smfr)
Comment 3 2018-01-31 16:55:05 PST
Created attachment 332824 [details] Patch
WebKit Commit Bot
Comment 4 2018-01-31 23:28:15 PST
Comment on attachment 332824 [details] Patch Clearing flags on attachment: 332824 Committed r227954: <https://trac.webkit.org/changeset/227954>
WebKit Commit Bot
Comment 5 2018-01-31 23:28:16 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-01-31 23:29:21 PST
<rdar://problem/37105147>
Note You need to log in before you can comment on or make changes to this bug.