Bug 182351

Summary: Add a release assertion to ensure timers are deleted in the right thread
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit Misc.Assignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ddkilzer, ggaren, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds a release assertion none

Ryosuke Niwa
Reported 2018-01-31 14:08:28 PST
Add a releaser assert in ~Timer to make sure a timer gets constructed & destructed in the same thread.
Attachments
Adds a release assertion (1.98 KB, patch)
2018-01-31 14:12 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2018-01-31 14:12:09 PST
Created attachment 332801 [details] Adds a release assertion
Radar WebKit Bug Importer
Comment 2 2018-01-31 14:12:38 PST
<rdar://problem/37086376>
David Kilzer (:ddkilzer)
Comment 3 2018-01-31 14:18:43 PST
Comment on attachment 332801 [details] Adds a release assertion r=me if EWS is happy
WebKit Commit Bot
Comment 4 2018-01-31 15:08:49 PST
Comment on attachment 332801 [details] Adds a release assertion Clearing flags on attachment: 332801 Committed r227934: <https://trac.webkit.org/changeset/227934>
WebKit Commit Bot
Comment 5 2018-01-31 15:08:50 PST
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 6 2018-01-31 16:22:01 PST
Good change, I wasted time earlier this week trying to guess whether this might be occurring in another bug. (It wasn't, but I didn't have an easy way to know that.)
Note You need to log in before you can comment on or make changes to this bug.