Bug 182313

Summary: Clients should register to StorageProcess with their service worker registration identifier
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 183274    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Fixing matchAll none

youenn fablet
Reported 2018-01-30 15:24:15 PST
Currently, they are doing so using service worker identifier which might change.
Attachments
Patch (20.35 KB, patch)
2018-01-30 16:44 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (20.40 KB, patch)
2018-02-28 16:44 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.15 KB, patch)
2018-03-01 15:11 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Fixing matchAll (20.80 KB, patch)
2018-03-02 08:21 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-01-30 16:44:23 PST
Created attachment 332723 [details] Patch
youenn fablet
Comment 2 2018-02-28 16:44:13 PST
Created attachment 334785 [details] Patch
Chris Dumez
Comment 3 2018-03-01 15:03:11 PST
Comment on attachment 334785 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334785&action=review > Source/WebCore/workers/service/server/SWServerRegistration.cpp:308 > + // NOOPFor each service worker client who is using registration: typo
youenn fablet
Comment 4 2018-03-01 15:11:55 PST
Created attachment 334859 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-03-01 16:04:10 PST
Comment on attachment 334859 [details] Patch for landing Clearing flags on attachment: 334859 Committed r229153: <https://trac.webkit.org/changeset/229153>
WebKit Commit Bot
Comment 6 2018-03-01 16:04:12 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-03-01 16:06:00 PST
<rdar://problem/38044403>
WebKit Commit Bot
Comment 8 2018-03-01 22:00:50 PST
Re-opened since this is blocked by bug 183274
youenn fablet
Comment 9 2018-03-02 08:21:47 PST
Created attachment 334898 [details] Fixing matchAll
WebKit Commit Bot
Comment 10 2018-03-02 11:17:07 PST
Comment on attachment 334898 [details] Fixing matchAll Clearing flags on attachment: 334898 Committed r229183: <https://trac.webkit.org/changeset/229183>
WebKit Commit Bot
Comment 11 2018-03-02 11:17:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.