Bug 182306

Summary: [RenderTreeBuilder] Move RenderRubyRun::rubyBaseSafe to RenderTreeBuilder::Ruby
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, darin, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2018-01-30 13:42:06 PST
only RenderTreeBuilder::Ruby calls it.
Attachments
Patch (7.05 KB, patch)
2018-01-30 13:48 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (3.67 KB, patch)
2018-02-01 13:13 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-30 13:44:02 PST
<rdar://problem/37041440>
zalan
Comment 2 2018-01-30 13:48:54 PST
Created attachment 332698 [details] Patch
WebKit Commit Bot
Comment 3 2018-01-30 14:41:01 PST
Comment on attachment 332698 [details] Patch Clearing flags on attachment: 332698 Committed r227856: <https://trac.webkit.org/changeset/227856>
WebKit Commit Bot
Comment 4 2018-01-30 14:41:03 PST
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2018-02-01 09:18:24 PST
Comment on attachment 332698 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332698&action=review > Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:359 > +RenderRubyBase* RenderTreeBuilder::Ruby::rubyBaseSafe(RenderRubyRun& rubyRun) Since the whole point is that this never returns null, I would change the return value to be a reference instead of a pointer.
zalan
Comment 6 2018-02-01 10:31:32 PST
(In reply to Darin Adler from comment #5) > Comment on attachment 332698 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332698&action=review > > > Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:359 > > +RenderRubyBase* RenderTreeBuilder::Ruby::rubyBaseSafe(RenderRubyRun& rubyRun) > > Since the whole point is that this never returns null, I would change the > return value to be a reference instead of a pointer. Good point! I'll do that.
zalan
Comment 7 2018-02-01 13:13:03 PST
Reopening to attach new patch.
zalan
Comment 8 2018-02-01 13:13:04 PST
Created attachment 332903 [details] Patch
WebKit Commit Bot
Comment 9 2018-02-01 13:48:40 PST
Comment on attachment 332903 [details] Patch Clearing flags on attachment: 332903 Committed r227980: <https://trac.webkit.org/changeset/227980>
WebKit Commit Bot
Comment 10 2018-02-01 13:48:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.