Summary: | WKWebView layout is sometimes wrong after rotation on iPhone X | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, commit-queue, dino, simon.fraser | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tim Horton
2018-01-30 13:25:26 PST
Created attachment 332692 [details]
Patch
Comment on attachment 332692 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332692&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:2472 > + // return UIEdgeInsetsAdd([_scrollView _contentScrollInset], self.safeAreaInsets, [_scrollView _edgesApplyingSafeAreaInsetsToContentInset]); Did you mean to leave this commented out? Heh, no, this was from futzing with testing. I’ll fix it, thanks! Created attachment 332713 [details]
Patch
Created attachment 332715 [details]
Patch
Comment on attachment 332715 [details] Patch Clearing flags on attachment: 332715 Committed r227869: <https://trac.webkit.org/changeset/227869> All reviewed patches have been landed. Closing bug. |