Bug 182284

Summary: [WebVR][GTK][WPE] Exclude OpenVR from tarballs
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 177298    
Attachments:
Description Flags
Patch mcatanzaro: review+

Sergio Villar Senin
Reported 2018-01-30 02:07:58 PST
[WebVR][GTK][WPE] Exclude OpenVR from tarballs
Attachments
Patch (4.28 KB, patch)
2018-01-30 02:10 PST, Sergio Villar Senin 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2018-01-30 02:10:30 PST
Created attachment 332640 [details] Patch
Michael Catanzaro
Comment 2 2018-01-30 05:59:04 PST
Comment on attachment 332640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332640&action=review Thanks > Source/cmake/OptionsWPE.cmake:51 > +WEBKIT_OPTION_DEFINE(USE_OPENVR "Whether to use OpenVR as WebVR backend." PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES}) This is right. I would just move it higher up in the file, above if (CMAKE_SYSTEM_NAME MATCHES "Linux"), and add a comment to parallel the other sections: # Private options specific to the WPE port. It won't be long before there are more such options.
Sergio Villar Senin
Comment 3 2018-01-30 08:18:33 PST
Committed r227788: <https://trac.webkit.org/changeset/227788>
Radar WebKit Bug Importer
Comment 4 2018-01-30 08:19:16 PST
<rdar://problem/37029301>
Note You need to log in before you can comment on or make changes to this bug.