| Summary: | [WebVR][GTK][WPE] Exclude OpenVR from tarballs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
| Component: | New Bugs | Assignee: | Sergio Villar Senin <svillar> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | mcatanzaro, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 177298 | ||||||
| Attachments: |
|
||||||
|
Description
Sergio Villar Senin
2018-01-30 02:07:58 PST
Created attachment 332640 [details]
Patch
Comment on attachment 332640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332640&action=review Thanks > Source/cmake/OptionsWPE.cmake:51 > +WEBKIT_OPTION_DEFINE(USE_OPENVR "Whether to use OpenVR as WebVR backend." PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES}) This is right. I would just move it higher up in the file, above if (CMAKE_SYSTEM_NAME MATCHES "Linux"), and add a comment to parallel the other sections: # Private options specific to the WPE port. It won't be long before there are more such options. Committed r227788: <https://trac.webkit.org/changeset/227788> |