Bug 182259

Summary: Clean up API after bugs 178240 and 176474
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mitz: review+

Description Alex Christensen 2018-01-29 12:58:11 PST 
Clean up API after bugs 178240 and 176474
Comment 1 Alex Christensen 2018-01-29 13:02:43 PST 
Created attachment 332572 [details]
Patch
Comment 2 Sam Weinig 2018-01-29 14:58:14 PST 
Comment on attachment 332572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332572&action=review

> Source/WebKit/ChangeLog:9
> +        * UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
> +        * UIProcess/API/Cocoa/WKWebViewPrivate.h:

Please add information about why these changes are being made.
Comment 3 Alex Christensen 2018-01-29 15:02:42 PST 
Created attachment 332585 [details]
Patch
Comment 4 Alex Christensen 2018-01-29 15:33:06 PST 
Created attachment 332589 [details]
Patch
Comment 5 mitz 2018-01-29 15:51:42 PST 
Comment on attachment 332589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332589&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:588
> +    EXPECT_EQ(static_cast<NSUInteger>([[change objectForKey:NSKeyValueChangeNewKey] integerValue]), _WKRectEdgeLeft | _WKRectEdgeRight);

Why not just do unsignedIntegerValue?
Comment 6 Alex Christensen 2018-01-29 17:27:31 PST 
trac.webkit.org/r227765
Comment 7 Radar WebKit Bug Importer 2018-01-29 17:30:49 PST 
<rdar://problem/37009361>