Bug 182259

Summary: Clean up API after bugs 178240 and 176474
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch mitz: review+

Alex Christensen
Reported 2018-01-29 12:58:11 PST
Clean up API after bugs 178240 and 176474
Attachments
Patch (4.15 KB, patch)
2018-01-29 13:02 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (4.98 KB, patch)
2018-01-29 15:02 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.51 KB, patch)
2018-01-29 15:33 PST, Alex Christensen 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-01-29 13:02:43 PST
Created attachment 332572 [details] Patch
Sam Weinig
Comment 2 2018-01-29 14:58:14 PST
Comment on attachment 332572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332572&action=review > Source/WebKit/ChangeLog:9 > + * UIProcess/API/Cocoa/WKUIDelegatePrivate.h: > + * UIProcess/API/Cocoa/WKWebViewPrivate.h: Please add information about why these changes are being made.
Alex Christensen
Comment 3 2018-01-29 15:02:42 PST
Created attachment 332585 [details] Patch
Alex Christensen
Comment 4 2018-01-29 15:33:06 PST
Created attachment 332589 [details] Patch
mitz
Comment 5 2018-01-29 15:51:42 PST
Comment on attachment 332589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332589&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:588 > + EXPECT_EQ(static_cast<NSUInteger>([[change objectForKey:NSKeyValueChangeNewKey] integerValue]), _WKRectEdgeLeft | _WKRectEdgeRight); Why not just do unsignedIntegerValue?
Alex Christensen
Comment 6 2018-01-29 17:27:31 PST
trac.webkit.org/r227765
Radar WebKit Bug Importer
Comment 7 2018-01-29 17:30:49 PST
<rdar://problem/37009361>
Note You need to log in before you can comment on or make changes to this bug.