Bug 182231

Summary: Add the support for running Speedometer 2.0 to run-benchmark
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, ews-watchlist, glenn, koivisto, lforschler, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Adds the support koivisto: review+

Ryosuke Niwa
Reported 2018-01-28 23:37:53 PST
Make it possible to run Speedometer 2.0 using run-benchmark.
Attachments
Adds the support (32.11 KB, patch)
2018-01-29 00:01 PST, Ryosuke Niwa 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-28 23:38:28 PST
<rdar://problem/36976267>
Ryosuke Niwa
Comment 2 2018-01-29 00:01:45 PST
Created attachment 332514 [details] Adds the support
Antti Koivisto
Comment 3 2018-01-29 07:53:19 PST
Comment on attachment 332514 [details] Adds the support View in context: https://bugs.webkit.org/attachment.cgi?id=332514&action=review > Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan:5 > + "svn_source": "https://svn.webkit.org/repository/webkit/trunk/PerformanceTests/Speedometer/@﷒0﷓", > + "webserver_benchmark_patch": "data/patches/webserver/Speedometer2.patch", Does this cover StyleBench too?
Ryosuke Niwa
Comment 4 2018-01-29 10:10:15 PST
(In reply to Antti Koivisto from comment #3) > Comment on attachment 332514 [details] > Adds the support > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332514&action=review > > > Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan:5 > > + "svn_source": "https://svn.webkit.org/repository/webkit/trunk/PerformanceTests/Speedometer/@﷒0﷓", > > + "webserver_benchmark_patch": "data/patches/webserver/Speedometer2.patch", > > Does this cover StyleBench too? No, we have to add a new plan file.
Ryosuke Niwa
Comment 5 2018-01-29 10:18:39 PST
Committed r227739: <https://trac.webkit.org/changeset/227739>
Note You need to log in before you can comment on or make changes to this bug.