Bug 182229

Summary: Make it possible for apps that use both WK1 and WK2 to use MessagePorts
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, jlewis3, kangil.han
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
API crash log none

Description Brady Eidson 2018-01-28 21:58:15 PST 
Make it possible for apps that use both WK1 and WK2 to use MessagePorts

The UIProcess-side of WK2 MessagePorts does not actually need to set the shared singleton provider as long as WebCore is updated to rely on it.
Comment 1 Brady Eidson 2018-01-28 21:58:33 PST 
rdar://problem/36739730
Comment 2 Brady Eidson 2018-01-28 22:10:34 PST 
Created attachment 332509 [details]
Patch
Comment 3 EWS Watchlist 2018-01-28 22:13:31 PST 
Attachment 332509 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/messageports/MessagePortChannelRegistry.h:38:  The parameter name "provider" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brady Eidson 2018-01-28 23:12:47 PST 
Created attachment 332511 [details]
Patch
Comment 5 WebKit Commit Bot 2018-01-29 09:45:22 PST 
Comment on attachment 332511 [details]
Patch

Clearing flags on attachment: 332511

Committed r227737: <https://trac.webkit.org/changeset/227737>
Comment 6 WebKit Commit Bot 2018-01-29 09:45:23 PST 
All reviewed patches have been landed.  Closing bug.