| Summary: | WebDriverBenchmarkRunner shouldn't poll global object every second | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW --- | ||
| Severity: | Normal | CC: | ap, dewei_zhu, lforschler, saam, slewis |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Right now, WebDriverBenchmarkRunner polls the global object of the benchmark every 1s. url = 'file://{root}/{plan_name}/{test_file}'.format(root=web_root, plan_name=self._plan_name, test_file=test_file) driver = self._browser_driver.launch_driver(url, self._plan['options'], self._build_dir) _log.info('Waiting on results from web browser') result = WebDriverWait(driver, self._plan['timeout'], poll_frequency=1.0).until(self._get_result) driver.quit() There is no way this won't affect the performance characteristics of the tested document.