Bug 182228 - WebDriverBenchmarkRunner shouldn't poll global object every second
Summary: WebDriverBenchmarkRunner shouldn't poll global object every second
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-28 19:03 PST by Ryosuke Niwa
Modified: 2018-01-28 19:03 PST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-01-28 19:03:18 PST 
Right now, WebDriverBenchmarkRunner polls the global object of the benchmark every 1s.

url = 'file://{root}/{plan_name}/{test_file}'.format(root=web_root, plan_name=self._plan_name, test_file=test_file)
driver = self._browser_driver.launch_driver(url, self._plan['options'], self._build_dir)
_log.info('Waiting on results from web browser')
result = WebDriverWait(driver, self._plan['timeout'], poll_frequency=1.0).until(self._get_result)
driver.quit()

There is no way this won't affect the performance characteristics of the tested document.