Bug 182211

Summary:

[WebAuthN] Add a compile-time feature flag

Product:

WebKit

Reporter:

Jiewen Tan <jiewen_tan>

Component:

WebCore Misc.

Assignee:

Jiewen Tan <jiewen_tan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, jiewen_tan, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

181943

Attachments:

Description	Flags
Patch	bfulgham: review+, bfulgham: commit-queue-
Patch for landing	none

Jiewen Tan

Reported 2018-01-26 22:31:14 PST

Add a feature flag for WebAuthN.

Attachments
Patch (79.74 KB, patch) 2018-01-26 22:44 PST, Jiewen Tan	bfulgham: review+ bfulgham: commit-queue-	Details Formatted Diff Diff
Patch for landing (79.85 KB, patch) 2018-01-29 14:34 PST, Jiewen Tan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-01-26 22:31:42 PST

<rdar://problem/36936365>

Jiewen Tan

Comment 2 2018-01-26 22:44:38 PST

Created attachment 332460 [details] Patch

Brent Fulgham

Comment 3 2018-01-28 16:49:10 PST

Comment on attachment 332460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332460&action=review Please revise the title to reflect that you are adding a COMPILE TIME feature flag, since we already had a runtime flag for enabling/disabling this experimental feature. > Source/JavaScriptCore/ChangeLog:3 > + [WebAuthN] Add a feature flag Add a compile-time feature flag > Source/WebCore/ChangeLog:9 > + Add a feature flag for WebAuthN as most of the functionalities are platform "Add a compile-time feature flag" "most of the functionality is platform dependent"

Jiewen Tan

Comment 4 2018-01-29 14:29:48 PST

Comment on attachment 332460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332460&action=review Thanks Brent for r+ the patch. >> Source/JavaScriptCore/ChangeLog:3 >> + [WebAuthN] Add a feature flag > > Add a compile-time feature flag Fixed. >> Source/WebCore/ChangeLog:9 >> + Add a feature flag for WebAuthN as most of the functionalities are platform > > "Add a compile-time feature flag" > > "most of the functionality is platform dependent" Fixed.

Jiewen Tan

Comment 5 2018-01-29 14:34:32 PST

Created attachment 332582 [details] Patch for landing

WebKit Commit Bot

Comment 6 2018-01-29 17:20:24 PST

Comment on attachment 332582 [details] Patch for landing Clearing flags on attachment: 332582 Committed r227764: <https://trac.webkit.org/changeset/227764>

Note You need to log in before you can comment on or make changes to this bug.