Bug 182201

Summary: Use double-quotes when serializing font-feature-settings
Product: WebKit Reporter: Chris Nardi <cnardi>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mmaxfield, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Update fast/text/font-face-javascript.html none

Chris Nardi
Reported 2018-01-26 17:33:03 PST
Use double-quotes when serializing font-feature-settings
Attachments
Patch (9.39 KB, patch)
2018-01-26 17:36 PST, Chris Nardi 		no flags
DetailsFormatted DiffDiff
Update fast/text/font-face-javascript.html (13.73 KB, patch)
2018-01-26 18:09 PST, Chris Nardi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Nardi
Comment 1 2018-01-26 17:36:55 PST
Created attachment 332441 [details] Patch
Chris Nardi
Comment 2 2018-01-26 18:09:28 PST
Created attachment 332446 [details] Update fast/text/font-face-javascript.html
Myles C. Maxfield
Comment 3 2018-01-30 15:43:52 PST
Comment on attachment 332446 [details] Update fast/text/font-face-javascript.html View in context: https://bugs.webkit.org/attachment.cgi?id=332446&action=review > LayoutTests/ChangeLog:6 > + Update tests with double-quotes instead of single-quotes. Why?
Myles C. Maxfield
Comment 4 2018-01-30 15:44:25 PST
(In reply to Myles C. Maxfield from comment #3) > Comment on attachment 332446 [details] > Update fast/text/font-face-javascript.html > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332446&action=review > > > LayoutTests/ChangeLog:6 > > + Update tests with double-quotes instead of single-quotes. > > Why? Oh, never mind, you explain it below.
WebKit Commit Bot
Comment 5 2018-01-30 16:08:49 PST
Comment on attachment 332446 [details] Update fast/text/font-face-javascript.html Clearing flags on attachment: 332446 Committed r227862: <https://trac.webkit.org/changeset/227862>
WebKit Commit Bot
Comment 6 2018-01-30 16:08:50 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-01-30 16:11:46 PST
<rdar://problem/37047234>
Simon Fraser (smfr)
Comment 8 2018-01-30 16:15:34 PST
Comment on attachment 332446 [details] Update fast/text/font-face-javascript.html View in context: https://bugs.webkit.org/attachment.cgi?id=332446&action=review > Source/WebCore/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). This should go above the description, after the bug number.
Note You need to log in before you can comment on or make changes to this bug.