| Summary: | Use double-quotes when serializing font-feature-settings | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Nardi <cnardi> | ||||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, mmaxfield, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Chris Nardi
2018-01-26 17:33:03 PST
Created attachment 332441 [details]
Patch
Created attachment 332446 [details]
Update fast/text/font-face-javascript.html
Comment on attachment 332446 [details] Update fast/text/font-face-javascript.html View in context: https://bugs.webkit.org/attachment.cgi?id=332446&action=review > LayoutTests/ChangeLog:6 > + Update tests with double-quotes instead of single-quotes. Why? (In reply to Myles C. Maxfield from comment #3) > Comment on attachment 332446 [details] > Update fast/text/font-face-javascript.html > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332446&action=review > > > LayoutTests/ChangeLog:6 > > + Update tests with double-quotes instead of single-quotes. > > Why? Oh, never mind, you explain it below. Comment on attachment 332446 [details] Update fast/text/font-face-javascript.html Clearing flags on attachment: 332446 Committed r227862: <https://trac.webkit.org/changeset/227862> All reviewed patches have been landed. Closing bug. Comment on attachment 332446 [details] Update fast/text/font-face-javascript.html View in context: https://bugs.webkit.org/attachment.cgi?id=332446&action=review > Source/WebCore/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). This should go above the description, after the bug number. |