Summary: | Resource Load Statistics: Introduce debug mode as experimental feature | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Wilander <wilander> | ||||||||
Component: | WebKit Misc. | Assignee: | John Wilander <wilander> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, dbates, ews-watchlist, japhet, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
John Wilander
2018-01-26 17:14:44 PST
Created attachment 332437 [details]
Patch
Created attachment 332554 [details]
Patch
Created attachment 332566 [details]
Patch
Comment on attachment 332566 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332566&action=review > Source/WebKit/Shared/WebPreferences.yaml:1196 > \ No newline at end of file I hope it wouldn't hurt to add a newline at the end of this file. Comment on attachment 332566 [details]
Patch
Thanks, Alex! Lack of a newline seems to mess up revision tracking both in Xcode and on Bugzilla, as can be seen in the formatted diff.
I think what happens is that by adding a newline to the previous entry in order to add your new one, you touch the last line of the previous entry and thus "revise" it. But I see what you're saying. Let's hope a newline is fine. Comment on attachment 332566 [details] Patch Rejecting attachment 332566 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 332566, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 227753 = c7d8175b884322f3dc6e97dd377b80344b80a3e5 r227754 = 19b1b43411899ad87c792acf81d60c4f9058a581 r227755 = 2d0589b491cc81522516c9eb3901667ac9a870c4 r227756 = 5cadb9d3c3216a3aa56f01b489c4dabbb3ca71de Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/6252911 Comment on attachment 332566 [details]
Patch
Trying the commit queue again.
Comment on attachment 332566 [details]
Patch
Nah.
Committed r227762: <https://trac.webkit.org/changeset/227762> |