Bug 182198

Summary: Make accessibility/mac/selection-notification-focus-change.html more reliable and re-enable it
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: AccessibilityAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, n_wang, samuel_white, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 182212    
Attachments:
Description Flags
Fixes the test thorton: review+

Ryosuke Niwa
Reported 2018-01-26 17:11:59 PST
Right now, accessibility/mac/selection-notification-focus-change.html is marked as pass & fail. This is because the test used to flakily fail. It now fails with the same output each time. We should update the test to be more reliable and re-enable it everywhere.
Attachments
Fixes the test (9.61 KB, patch)
2018-01-26 17:26 PST, Ryosuke Niwa 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-26 17:12:27 PST
<rdar://problem/36930258>
Ryosuke Niwa
Comment 2 2018-01-26 17:26:40 PST
Created attachment 332438 [details] Fixes the test
chris fleizach
Comment 3 2018-01-26 17:39:43 PST
Comment on attachment 332438 [details] Fixes the test View in context: https://bugs.webkit.org/attachment.cgi?id=332438&action=review > LayoutTests/accessibility/mac/selection-notification-focus-change-expected.txt:21 > +FAIL userInfo["AXTextSelectionChangedFocus"] should be true (of type boolean). Was undefined (of type undefined). is this expected to check in the FAIL case?
Ryosuke Niwa
Comment 4 2018-01-26 17:44:50 PST
(In reply to chris fleizach from comment #3) > Comment on attachment 332438 [details] > Fixes the test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332438&action=review > > > LayoutTests/accessibility/mac/selection-notification-focus-change-expected.txt:21 > > +FAIL userInfo["AXTextSelectionChangedFocus"] should be true (of type boolean). Was undefined (of type undefined). > > is this expected to check in the FAIL case? No, but I have a fix coming up soon :). I wanted to land the test change first so that it's easy to see what code change fixes which test case instead of changing the code & the test at the same time.
Ryosuke Niwa
Comment 5 2018-01-26 22:26:11 PST
Committed r227713: <https://trac.webkit.org/changeset/227713>
Note You need to log in before you can comment on or make changes to this bug.